Fix(dependencies/chip): latest input dependencies and new styling for the chip tested #151
Conversation
CarloBar1
changed the title
@cristinecula addressed this in my latest commit. The chip had an odd styling, but I added an exported part for it. The uncentering was due to an uneven padding, but I fixed that adding an extra margin to compensate it. Also, the odd spacing was due to a mistake - I set "CHoose color" as placeholder and not as label - fixed. |
| @@ -31,7 +31,7 @@ type AProps<I> = Omit<Props<I>, keyof RProps<I>> & | |||
|
|
|||
| const blank = () => nothing; | |||
|
|
|||
| const inputParts = ['input', 'control', 'label', 'line', 'error'] | |||
| const inputParts = ['input', 'control', 'label', 'line', 'error', 'chip', 'chip-text', 'chip-clear'] | |||
There was a problem hiding this comment.
inputParts gets set on <cosmoz-input [..] exportparts=${inputParts}, but the parts you have added to the list are not part of cosmoz-input. This change has no effect.
| .limit=${5} | ||
| .textProperty=${'text'} | ||
| .value=${colors[0]} | ||
| contour |
There was a problem hiding this comment.
What is up with this contour attribute?
| cosmoz-autocomplete::part(input-control) { | ||
| margin: 0 8px; | ||
| } | ||
| cosmoz-autocomplete::part(chip-clear) { | ||
| margin-left: 4px; | ||
| } |
There was a problem hiding this comment.
I think you should expose these as css variables: --cosmoz-autocomplete-input-control-margin and --cosmoz-autocomplete-chip-clear-margin, instead of relying on parts. Parts are good, but css variables are better, because they cascade.
About feature AB#11519 - part of the inputs restyling. Dependencies update and testing of a more squared chip for the new input design.
